Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bugs for console and keeper #755

Merged
merged 5 commits into from
Dec 6, 2023
Merged

fix bugs for console and keeper #755

merged 5 commits into from
Dec 6, 2023

Conversation

LanternLee
Copy link
Collaborator

@LanternLee LanternLee commented Dec 5, 2023 •
edited
Loading

  1. keeper rdb file handle leak
  2. console leader fgc in idc down
  3. console unhealthy-redis-api down in idc down
  4. console handle zk event in wrong order
  5. support repl like: redis->keeper/appler->redis->keeper/appler->redis

@codecov Codecov
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Attention: 138 lines in your changes are missing coverage. Please review.

Comparison is base (80b56f6) 53.36% compared to head (24b2c57) 53.27%.
Report is 4 commits behind head on master.

Files Patch % Lines
.../console/controller/api/data/meta/ClusterInfo.java 0.00% 26 Missing ⚠️
...va/com/ctrip/xpipe/redis/console/dto/ShardDTO.java 0.00% 22 Missing ⚠️
...redis/console/service/impl/ClusterServiceImpl.java 0.00% 21 Missing ⚠️
...is/console/controller/api/data/meta/ShardInfo.java 0.00% 17 Missing ⚠️
...console/proxy/impl/DefaultProxyChainCollector.java 0.00% 17 Missing ⚠️
.../com/ctrip/xpipe/redis/console/dto/ClusterDTO.java 0.00% 7 Missing ⚠️
...e/controller/api/data/ClusterUpdateController.java 0.00% 6 Missing ⚠️
...edis/console/service/impl/DefaultDelayService.java 68.42% 5 Missing and 1 partial ⚠️
...com/ctrip/xpipe/cluster/AbstractLeaderElector.java 0.00% 5 Missing ⚠️
...ip/xpipe/redis/core/protocal/cmd/RdbOnlyPsync.java 0.00% 5 Missing ⚠️
... and 2 more
Additional details and impacted files 
@@             Coverage Diff              @@
##             master     #755      +/-   ##
============================================
- Coverage     53.36%   53.27%   -0.09%     
- Complexity    10037    10049      +12     
============================================
  Files          1746     1749       +3     
  Lines         54697    54828     +131     
  Branches       5675     5689      +14     
============================================
+ Hits          29189    29211      +22     
- Misses        23019    23135     +116     
+ Partials       2489     2482       -7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LanternLee LanternLee merged commit 59f20fc into master Dec 6, 2023
1 of 3 checks passed
@LanternLee LanternLee deleted the bugfix/keeper-rdb-handle-leak branch December 22, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilongjiao lilongjiao lilongjiao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LanternLee @lilongjiao